Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve psltool PR check #2218

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Improve psltool PR check #2218

merged 1 commit into from
Oct 15, 2024

Conversation

simon-friedberger
Copy link
Contributor

Enable DNS checks for PR action.

Rename Client to GHRepo because the internal github.Client and the github.Client from the library confuses my IDE.

Pass the GHRepo to validateTXTRecords so it uses the correct repository.

@simon-friedberger
Copy link
Contributor Author

@danderson Have a look? :)

danderson
danderson reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@danderson danderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I don't have the github permissions to hit the approve button, but 👍

tools/psltool/psltool.go Outdated Show resolved Hide resolved
tools/internal/github/pr.go Outdated Show resolved Hide resolved
@simon-friedberger simon-friedberger merged commit 29dfff7 into master Oct 15, 2024
3 checks passed
@simon-friedberger simon-friedberger deleted the prcheck branch October 15, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danderson danderson danderson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon-friedberger @danderson